New optional `.gitlab-ci-local-ignores` file to list file to ignore to sync with jobs by jrd · Pull Request #1884 · firecow/gitlab-ci-local

jrd · 2026-06-16T07:50:51Z

The file could also be specified on command line.

Format should follow the rsync ignore format.

Also never sync the .git/lfs directory which, if it exists, is usually huge.

This pull request could replace #1883 if this solution is preferred.

Summary by cubic

Add an optional .gitlab-ci-local-ignores file and a --ignores-file flag to exclude files from rsync across pipelines, stages, and shell isolation. Always exclude .git/lfs, and safely escape the ignore file path.

New Features
- Support .gitlab-ci-local-ignores using rsync ignore syntax (default path).
- Add --ignores-file to set a custom ignore file path.
Bug Fixes
- Escape the ignores file path in rsync to prevent command injection.

^{Written for commit dc2b57b. Summary will update on new commits.}

cubic-dev-ai

No issues found across 5 files

_{Re-trigger cubic}

firecow · 2026-06-22T11:16:43Z

@jrd Can we add a test to verify and avoid future regressions?

jrd · 2026-06-22T11:22:52Z

I’ll add a test later this day (I’m UTC+2)

jrd · 2026-06-25T11:53:45Z

@jrd Can we add a test to verify and avoid future regressions?

Done. Hope the test is good enough… (because I didn’t cover all cases)

firecow · 2026-07-31T07:02:43Z

+            `--exclude-from=<(git ls-files -o --directory | awk '{print "/"$0}')`, // eslint-disable-line @stylistic/quotes
+            `--exclude-from=<(cat ${Utils.safeBashString(ignoresFile)} 2>/dev/null || true)`,


Suggested change

`--exclude-from=<(git ls-files -o --directory | awk '{print "/"$0}')`, // eslint-disable-line @stylistic/quotes

`--exclude-from=<(cat ${Utils.safeBashString(ignoresFile)} 2>/dev/null || true)`,

"--exclude-from=<(git ls-files -o --directory | awk '{print \"/\"$0}')",

...await fs.pathExists(ignoresFile) ? [`--exclude-from=${Utils.safeBashString(ignoresFile)}`] : [],

firecow · 2026-07-31T07:02:43Z

        })
+        .option("ignores-file", {
+            type: "string",
+            description: "Path to a ignores file",


Suggested change

description: "Path to a ignores file",

description: "Path to an ignores file",

firecow · 2026-07-31T07:02:43Z

        }
        parser = await Parser.create(argv, writeStreams, pipelineIid, jobs);
-        await Utils.rsyncTrackedFiles(cwd, stateDir, ".docker");
+        await Utils.rsyncTrackedFiles(cwd, stateDir, `${cwd}/${argv.ignoresFile}`, ".docker");


Suggested change

await Utils.rsyncTrackedFiles(cwd, stateDir, `${cwd}/${argv.ignoresFile}`, ".docker");

await Utils.rsyncTrackedFiles(cwd, stateDir, path.resolve(cwd, argv.ignoresFile), ".docker");

firecow · 2026-07-31T07:02:43Z

        const pipelineIid = await state.getPipelineIid(cwd, stateDir);
        parser = await Parser.create(argv, writeStreams, pipelineIid, jobs);
-        await Utils.rsyncTrackedFiles(cwd, stateDir, ".docker");
+        await Utils.rsyncTrackedFiles(cwd, stateDir, `${cwd}/${argv.ignoresFile}`, ".docker");


Suggested change

await Utils.rsyncTrackedFiles(cwd, stateDir, `${cwd}/${argv.ignoresFile}`, ".docker");

await Utils.rsyncTrackedFiles(cwd, stateDir, path.resolve(cwd, argv.ignoresFile), ".docker");

firecow · 2026-07-31T07:02:43Z

        const pipelineIid = await state.incrementPipelineIid(cwd, stateDir);
        parser = await Parser.create(argv, writeStreams, pipelineIid, jobs);
-        await Utils.rsyncTrackedFiles(cwd, stateDir, ".docker");
+        await Utils.rsyncTrackedFiles(cwd, stateDir, `${cwd}/${argv.ignoresFile}`, ".docker");


Suggested change

await Utils.rsyncTrackedFiles(cwd, stateDir, `${cwd}/${argv.ignoresFile}`, ".docker");

await Utils.rsyncTrackedFiles(cwd, stateDir, path.resolve(cwd, argv.ignoresFile), ".docker");

firecow · 2026-07-31T07:02:43Z

        // Copy git tracked files to build folder if shell isolation enabled.
        if (!imageName && this.argv.shellIsolation) {
-            await Utils.rsyncTrackedFiles(cwd, stateDir, `${safeJobName}`);
+            await Utils.rsyncTrackedFiles(cwd, stateDir, `${cwd}/${this.argv.ignoresFile}`, `${safeJobName}`);


Suggested change

await Utils.rsyncTrackedFiles(cwd, stateDir, `${cwd}/${this.argv.ignoresFile}`, `${safeJobName}`);

await Utils.rsyncTrackedFiles(cwd, stateDir, path.resolve(cwd, this.argv.ignoresFile), `${safeJobName}`);

firecow · 2026-07-31T07:02:43Z

+---
+test-job:
+  script:
+    - tree -a


Suggested change

- tree -a

firecow · 2026-07-31T07:19:13Z

        }
        parser = await Parser.create(argv, writeStreams, pipelineIid, jobs);
-        await Utils.rsyncTrackedFiles(cwd, stateDir, ".docker");
+        await Utils.rsyncTrackedFiles(cwd, stateDir, `${cwd}/${argv.ignoresFile}`, ".docker");


${cwd}/${argv.ignoresFile} breaks --ignores-file /abs/path → ${cwd}//abs/path. Verified: original reports test-job > 2 (exclusions silently dropped), 1 after path.resolve. The 2>/dev/null || true is what hides it; a typo'd path fails silently too.

I get it, thanks.

firecow · 2026-07-31T07:19:13Z

+---
+test-job:
+  script:
+    - tree -a


Not asserted, and not installed here, so the whole test file fails locally with tree: command not found. Passes only because GitHub runners ship it.

oh I see, can I replace it with find ?

…o sync with jobs. The file could also be specified on command line. Format should follow the `rsync` ignore format. Also never sync the `.git/lfs` directory which, if it exists, is usually huge.

jrd · 2026-08-06T12:15:33Z

Should be good now.

cubic-dev-ai Bot reviewed Jun 16, 2026

View reviewed changes

jrd force-pushed the ignores_file branch from b5817a0 to 4931412 Compare June 22, 2026 11:10

jrd mentioned this pull request Jun 22, 2026

Honor dockerignore #1883

Closed

firecow reviewed Jun 22, 2026

View reviewed changes

Comment thread src/utils.ts Outdated

jrd force-pushed the ignores_file branch from d7208a9 to de52548 Compare June 25, 2026 11:52

jrd requested a review from firecow June 30, 2026 23:53

firecow reviewed Jul 31, 2026

View reviewed changes

New optional .gitlab-ci-local-ignores file to list file to ignore t…

dc2b57b

…o sync with jobs. The file could also be specified on command line. Format should follow the `rsync` ignore format. Also never sync the `.git/lfs` directory which, if it exists, is usually huge.

jrd force-pushed the ignores_file branch from de52548 to dc2b57b Compare August 5, 2026 16:05

		`--exclude-from=<(git ls-files -o --directory \| awk '{print "/"$0}')`, // eslint-disable-line @stylistic/quotes
		`--exclude-from=<(cat ${Utils.safeBashString(ignoresFile)} 2>/dev/null \|\| true)`,

	description: "Path to a ignores file",
	description: "Path to an ignores file",

	await Utils.rsyncTrackedFiles(cwd, stateDir, `${cwd}/${argv.ignoresFile}`, ".docker");
	await Utils.rsyncTrackedFiles(cwd, stateDir, path.resolve(cwd, argv.ignoresFile), ".docker");

Conversation

jrd commented Jun 16, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

firecow commented Jun 22, 2026

Uh oh!

Uh oh!

jrd commented Jun 22, 2026

Uh oh!

jrd commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

firecow Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

firecow Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jrd commented Aug 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jrd commented Jun 16, 2026 •

edited by cubic-dev-ai Bot

Loading

jrd commented Jun 25, 2026 •

edited

Loading

firecow Jul 31, 2026 •

edited

Loading

firecow Jul 31, 2026 •

edited

Loading